From: Cristobal Forno <cforn...@linux.ibm.com> Date: Tue, 18 Aug 2020 16:53:33 -0500
> @@ -1524,7 +1519,7 @@ static netdev_tx_t ibmvnic_xmit(struct sk_buff *skb, > struct net_device *netdev) > unsigned int offset; > int num_entries = 1; > unsigned char *dst; > - u64 *handle_array; > + u64 handle; > int index = 0; > u8 proto = 0; > netdev_tx_t ret = NETDEV_TX_OK; Please preserve the reverse christmas tree ordering of local variables here. Otherwise the patch looks fine to me.
