Ganji Aravind wrote: > Work request used for sending loopback packet needs to add > the firmware work request only once. So, fix by using > correct structure size. > > Fixes: 7235ffae3d2c ("cxgb4: add loopback ethtool self-test") > Signed-off-by: Ganji Aravind <ganji.arav...@chelsio.com>
changes look ok, but to understand why this change fixed the bug, you could have just mentioned that the cpl_tx_pkt struct has a _core member inside of it, and then I wouldn't have had to waste review time digging through the code in the kernel. Reviewed-by: Jesse Brandeburg <jesse.brandeb...@intel.com>