> > +static int dsa_devlink_info_get(struct devlink *dl,
> > + struct devlink_info_req *req,
> > + struct netlink_ext_ack *extack)
> > +{
> > + struct dsa_switch *ds;
> > +
> > + ds = dsa_devlink_to_ds(dl);
> > +
>
> Why not place the declaration and the assignment on a single line?This code went through a few refactors. Probably at some point i could not keep reverse christmass tree so had to split it. And it then never got put back together again. I will fix it up for v2. Andrew
