On 8/15/20 11:33 AM, Hauke Mehrtens wrote:
> netif_tx_napi_add() should be used for NAPI in the TX direction instead
> of the netif_napi_add() function.
>
> Fixes: fe1a56420cf2 ("net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver")
> Signed-off-by: Hauke Mehrtens <ha...@hauke-m.de>
> ---
> drivers/net/ethernet/lantiq_xrx200.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/lantiq_xrx200.c
> b/drivers/net/ethernet/lantiq_xrx200.c
> index 1feb9fc710e0..f34e4dc8c661 100644
> --- a/drivers/net/ethernet/lantiq_xrx200.c
> +++ b/drivers/net/ethernet/lantiq_xrx200.c
> @@ -502,7 +502,7 @@ static int xrx200_probe(struct platform_device *pdev)
>
> /* setup NAPI */
> netif_napi_add(net_dev, &priv->chan_rx.napi, xrx200_poll_rx, 32);
> - netif_napi_add(net_dev, &priv->chan_tx.napi, xrx200_tx_housekeeping,
> 32);
> + netif_tx_napi_add(net_dev, &priv->chan_tx.napi, xrx200_tx_housekeeping,
> 32);
>
> platform_set_drvdata(pdev, priv);
>
>
This is not a must, simply a matter of (small) optimization in
the very rare case of busy polling users.
The Fixes: tag here is not necessary.
