James Chapman wrote: > [PPPOL2TP]: Add PPP-over-L2TP driver core. A couple more comments:
- seq_file handling doesn't check seq_printf return values and tries to dump the entire hash table at once, which might exceed the available room. - there appear to be no checks for duplicate session IDs on session creation. - try_module_get/put_module in pppol2tp_create look unnecessary - kfree can take NULL pointers - direct dereference of user pointer in pppol2tp_sendmsg debugging - jiffies.h includes conversion functions for HZ <-> msecs - Any particular reason why the SKB_CB is put after inet_skb_parm? On 64 bit this almost reaches the limit, might be safer to put it at the beginning. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
