On 2020-07-10 8:04 a.m., Jamal Hadi Salim wrote:
On 2020-07-09 8:19 a.m., Jiri Pirko wrote:
Thu, Jul 09, 2020 at 01:00:26PM CEST, j...@mojatatu.com wrote:
Main point is: classifying based on hash(and for that
matter any other metadata like mark) is needed as a general
utility for the system and should not be only available for
flower. The one big reason we allow all kinds of classifiers
in tc is in the name of "do one thing and do it well".
Sure. That classifier can exist, no problem. At the same time, flower
can match on it as well. There are already multiple examples of
classifiers matching on the same thing. I don't see any problem there.
I keep pointing to the issues and we keep circling back
to your desire to add it to flower. I emphatize with the
desire to have flower as a one stop shop for all things classification
but this is at the expense of other classifiers. I too need this for
offloading as well as getting the RSS proper feature i described.ets
make progress.
You go ahead - i will submit a version to add it as a separate
hash classifier.
Some cycles opened up - I will work on this in the next day or
two now that your patches are in...
cheers,
jamal
