Stefano Brivio <sbri...@redhat.com> wrote: > Currently, PMTU discovery for UDP tunnels only works if packets are > routed to the encapsulating interfaces, not bridged. > > This results from the fact that we generally don't have valid routes > to the senders we can use to relay ICMP and ICMPv6 errors, and makes > PMTU discovery completely non-functional for VXLAN and GENEVE ports of > both regular bridges and Open vSwitch instances. > > If the sender is local, and packets are forwarded to the port by a > regular bridge, all it takes is to generate a corresponding route > exception on the encapsulating device. The bridge then finds the route > exception carrying the PMTU value estimate as it forwards frames, and > relays ICMP messages back to the socket of the local sender. Patch 1/6 > fixes this case. > > If the sender resides on another node, we actually need to reply to > IP and IPv6 packets ourselves and send these ICMP or ICMPv6 errors > back, using the same encapsulating device. Patch 2/6, based on an > original idea by Florian Westphal, adds the needed functionality, > while patches 3/6 and 4/6 add matching support for VXLAN and GENEVE. > > Finally, 5/6 and 6/6 introduce selftests for all combinations of > inner and outer IP versions, covering both VXLAN and GENEVE, with > both regular bridges and Open vSwitch instances.
Thanks for taking over and brining this into shape, this looks good to me. Given such setups will become easily get stuck on first pmtu update it would be good to get this applied now, even tough merge window is already open.