Thanks! On Mon, Aug 3, 2020 at 2:50 AM Willem de Bruijn <willemdebruijn.ker...@gmail.com> wrote: > > It's [PATCH net v3], not [net v3]
Sorry. My mistake. I'll pay attention next time. I'm currently thinking about changing the subject to reflect that we added a "skb->len" check. Should I number the new patch as v1 or continue to number it as v4? > > + if (skb->len < 1) > > + goto drop; > > + > > Might be worth a comment along the lines of: /* upper layers pass a > control byte. must validate pf_packet input */ OK. I'll add the comment before it to make its meaning clearer. > > + dev->hard_header_len = 0; > > Technically not needed. The struct is allocated with kvzalloc, z for > __GFP_ZERO. Fine to leave if intended as self-describing comment, of > course. Thanks for pointing out! I think I can leave it as a self-describing comment. Thanks!
