Re: [net-next v2 2/5] devlink: introduce flash update overwrite mask

[Jiri Pirko]

Sat, Aug 01, 2020 at 02:21:56AM CEST, jacob.e.kel...@intel.com wrote:

[...]

>+      nla_mask = info->attrs[DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK];
>+      if (nla_mask) {
>+              if (!(supported_params & 
>DEVLINK_SUPPORT_FLASH_UPDATE_OVERWRITE_MASK)) {
>+                      NL_SET_ERR_MSG_ATTR(info->extack, nla_mask,
>+                                          "overwrite is not supported");
>+                      return -EOPNOTSUPP;
>+              }
>+              params.overwrite_mask = nla_get_u32(nla_mask);

It's a bitfield, should be NL_ATTR_TYPE_BITFIELD32.