On 31/07/2020 21:18, Jakub Kicinski wrote: > On Fri, 31 Jul 2020 13:58:35 +0100 Edward Cree wrote: >> + default: >> + /* Host interface says "Drivers should ignore design parameters >> + * that they do not recognise." >> + */ >> + netif_info(efx, probe, efx->net_dev, >> + "Ignoring unrecognised design parameter %u\n", >> + reader->type); > Is this really important enough to spam the logs with? Well, it implies your NIC (FPGA image) is newer than your driver, and saying things the driver doesn't understand; I feel like that should be recorded somewhere. Maybe this should be a netif_dbg() instead? (Or is this a subtle way of telling me "you should implement devlink health"?) > Should you warn if the TLV stream ends half-way through an entry? Fair point, yes we should.
-ed
