>> Thus, here we create and store a private copy of this structure
>> in qed_dev root object.
>
> Please include example output of devlink info on you device.
Hi Jakub, will do. Here is an example:
~$ sudo ~/iproute2/devlink/devlink dev info
pci/0000:01:00.0:
driver qed
serial_number REE1915E44552
versions:
running:
fw 8.42.2.0
stored:
fw.mgmt 8.52.10.0
pci/0000:01:00.1:
driver qed
serial_number REE1915E44552
versions:
running:
fw 8.42.2.0
stored:
fw.mgmt 8.52.10.0
>> + memcpy(buf, cdev->hwfns[0].hw_info.part_num,
> sizeof(cdev->hwfns[0].hw_info.part_num));
>> + buf[sizeof(cdev->hwfns[0].hw_info.part_num)] = 0;
>
> Part number != serial number. What's the thing you're reporting here
> actually identifying.
>From user manual and configuration point of view thats a serial number.
Existing internal structures name that as part number, double checked
the documentation - in this hardware manual these two things are the same.
> DEVLINK_INFO_VERSION_GENERIC_FW_MGMT, buf);
>> + if (err)
>> + return err;
>
> Assuming MFW means management FW - this looks good.
>> + return devlink_info_version_running_put(req,
Right,
> DEVLINK_INFO_VERSION_GENERIC_FW, buf);
>
> But what's this one?
This one is a fast path firmware which is being loaded from driver
dynamically. I can put this explanation to the patch description.
Regards
Igor
