On Thu, 30 Jul 2020 17:00:58 -0700 Shannon Nelson wrote: > + max_cnt = lif->ionic->ntxqs_per_lif; > + if (ch->combined_count) { > + if (!test_bit(IONIC_LIF_F_SPLIT_INTR, lif->state) && > + (ch->combined_count == lif->nxqs)) { > + netdev_info(netdev, "No change a\n"); > + return 0; > + } > + > + netdev_info(netdev, "Changing queue count from %d to %d\n", > + lif->nxqs, ch->combined_count); > + } else { > + max_cnt /= 2; > + if (test_bit(IONIC_LIF_F_SPLIT_INTR, lif->state) && > + (ch->rx_count == lif->nxqs)) { > + netdev_info(netdev, "No change b\n"); > + return 0; > + } > + > + netdev_info(netdev, "Changing queue count from %d to %d\n", > + lif->nxqs, ch->rx_count); > + }
A little verbose there with the printin' but overall looks reasonable: Reviewed-by: Jakub Kicinski <k...@kernel.org>