On 7/30/20 4:36 PM, David Miller wrote: > From: Bryan Whitehead <bryan.whiteh...@microchip.com> > Date: Mon, 27 Jul 2020 13:18:28 -0400 > >> @@ -929,6 +929,77 @@ static bool vsc8574_is_serdes_init(struct phy_device >> *phydev) >> } >> >> /* bus->mdio_lock should be locked when using this function */ >> +/* Page should already be set to MSCC_PHY_PAGE_EXTENDED_GPIO */ >> +static int vsc8574_micro_command(struct phy_device *phydev, u16 command) > ... >> +/* bus->mdio_lock should be locked when using this function */ > > Please don't dup this comment, it's not appropriate.
Agree put a mutex assertion instead if you want to catch offenders at run time? -- Florian
