On Thu, Jul 30, 2020 at 08:53:26AM -0700, Richard Cochran wrote:
> On Wed, Jul 29, 2020 at 11:07:48PM +0100, Russell King - ARM Linux admin
> wrote:
> > What I see elsewhere in ethtool is that the MAC has the ability to
> > override the phylib provided functionality - for example,
> > __ethtool_get_sset_count(), __ethtool_get_strings(), and
> > ethtool_get_phy_stats(). Would it be possible to do the same in
> > __ethtool_get_ts_info(), so at least a MAC driver can then decide
> > whether to propagate the ethtool request to phylib or not, just like
> > it can do with the SIOC*HWTSTAMP ioctls? Essentially, reversing the
> > order of:
> >
> > if (phy_has_tsinfo(phydev))
> > return phy_ts_info(phydev, info);
> > if (ops->get_ts_info)
> > return ops->get_ts_info(dev, info);
> >
> > ?
>
> I don't see a simple solution. I think no matter what, the MAC
> drivers need work to allow PHY time stamping, and the great majority
> of users and driver authors are happy with MAC time stamping.
What I ended up doing was:
if (ops->get_ts_info) {
ret = ops->get_ts_info(dev, info);
if (ret != -EOPNOTSUPP)
return ret;
}
if (phy_has_tsinfo(phydev))
return phy_ts_info(phydev, info);
...
which gives the MAC first refusal. If the MAC wishes to defer to
phylib or the default, it can just return -EOPNOTSUPP.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
