On Thu, Jul 30, 2020 at 11:41 AM Kurt Kanzenbach <[email protected]> wrote:
> On Thu Jul 30 2020, Grygorii Strashko wrote:
> > On 30/07/2020 11:00, Kurt Kanzenbach wrote:
> >> + msgtype = ptp_get_msgtype(hdr, ptp_class);
> >> + seqid = be16_to_cpu(hdr->sequence_id);
> >
> > Is there any reason to not use "ntohs()"?
>
> This is just my personal preference, because I think it's more
> readable. Internally ntohs() uses be16_to_cpu(). There's no technical
> reason for it.
I think for traditional reasons, code in net/* tends to use ntohs()
while code in drivers/* tends to use be16_to_cpu().
In drivers/net/* the two are used roughly the same, though I guess
one could make the argument that be16_to_cpu() would be
more appropriate for data structures exchanged with hardware
while ntohs() makes sense on data structures sent over the
network.
Arnd
