> -----邮件原件----- > 发件人: Jakub Kicinski [mailto:k...@kernel.org] > 发送时间: 2020年7月30日 5:20 > 收件人: Li,Rongqing <lirongq...@baidu.com> > 抄送: Tony Nguyen <anthony.l.ngu...@intel.com>; da...@davemloft.net; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > jeffrey.t.kirs...@intel.com; Andrew Bowers <andrewx.bow...@intel.com> > 主题: Re: [net-next 2/6] i40e: prefetch struct page of Rx buffer conditionally > > On Wed, 29 Jul 2020 06:20:47 +0000 Li,Rongqing wrote: > > > Looks like something that belongs in a common header not > > > (potentially > > > multiple) C sources. > > > > Not clear, how should I change? > > Can you add something like: > > static inline void prefetch_page_address(struct page *page) { #if > defined(WANT_PAGE_VIRTUAL) || defined(HASHED_PAGE_VIRTUAL) > prefetch(page); > #endif > } > > to mm.h or prefetch.h or i40e.h or some other header? That's preferred over > adding #ifs directly in the source code.
Thanks, I will send a new version -Li
