On Wed, 2020-07-29 at 09:17 +0300, Or Gerlitz wrote:
> On Tue, Jul 28, 2020 at 11:07 PM Saeed Mahameed <sae...@mellanox.com>
> wrote:
> > When setting the PF interface up/down, notify the firmware to
> > update
> > uplink state via MODIFY_VPORT_STATE, when E-Switch is enabled.
> > This behavior will prevent sending traffic out on uplink port when
> > PF is
> > down, such as sending traffic from a VF interface which is still
> > up.
> > Currently when calling mlx5e_open/close(), the driver only sends
> > PAOS
> > command to notify the firmware to set the physical port state to
> > up/down, however, it is not sufficient. When VF is in "auto" state,
> > it
> > follows the uplink state, which was not updated on
> > mlx5e_open/close()
> > before this patch.
> > When switchdev mode is enabled and uplink representor is first
> > enabled,
> > set the uplink port state value back to its FW default "AUTO".
>
> So this is not the legacy mode "auto" vf vport state but rather
> something else?
>
Or, this is the uplink esw port and not the PF's, auto means
FW/HW manages the state according to the actual physical link state.
> If this is the case what is the semantics of the firmware "auto"
> state and
> how it related to the switchdev vport representors
> architecture/behaviour?
>
No change in the current switchdev behavior, only for legacy and NONE
mode.
>
> > Fixes: 63bfd399de55 ("net/mlx5e: Send PAOS command on interface
> > up/down")
