Hi Herbert, David
On 7/27/2020 3:29 PM, Ayush Sawal wrote:
On 7/27/2020 2:46 PM, Steffen Klassert wrote:
On Sat, Jul 25, 2020 at 04:20:34PM +1000, Herbert Xu wrote:
On Fri, Jul 24, 2020 at 05:01:08PM -0700, David Miller wrote:
Please start submitting chcr patches to the crypto subsystem, where it
belongs, instead of the networking GIT trees.
Hi Dave:
I think this patch belongs to the networking tree. The reason is
that it's related to xfrm offload which has nothing to do with the
Crypto API.
Hm, I think some of this code is just misplaced under drivers/crypto.
All functions in 'drivers/crypto/chelsio/chcr_ipsec.c' implement
networking (IPsec). So it should be under drivers/net, then it
can be merged via the net or net-next tree as usual for network
drivers.
Ok,
We have started the work towards shifting inline ipsec, nic tls & chtls
code present in drivers/crypto/chelsio/ into
drivers/net/ethernet/chelsio/. Only co-processor code will exist in the
drivers/crypto/chelsio directory.
Thanks,
Ayush
In the process of moving inline tls stuff from crypto to net, we have
directory structure change.
Can you please suggest correct tree to submit changes to avoid merge
conflicts ?
Here is the file diff stats:
MAINTAINERS | 9 ++
drivers/crypto/chelsio/Kconfig | 11 ---
drivers/crypto/chelsio/Makefile | 1 -
drivers/crypto/chelsio/chcr_algo.h | 33 -------
drivers/crypto/chelsio/chcr_core.h | 53 ------------
drivers/net/ethernet/chelsio/Kconfig | 11 +++
drivers/net/ethernet/chelsio/Makefile | 1 +
.../ethernet}/chelsio/chtls/Makefile | 0
.../ethernet}/chelsio/chtls/chtls.h | 86 +++++++++++++++++++
.../ethernet}/chelsio/chtls/chtls_cm.c | 0
.../ethernet}/chelsio/chtls/chtls_cm.h | 0
.../ethernet}/chelsio/chtls/chtls_hw.c | 0
.../ethernet}/chelsio/chtls/chtls_io.c | 0
.../ethernet}/chelsio/chtls/chtls_main.c | 0
14 files changed, 107 insertions(+), 98 deletions(-)
rename drivers/{crypto => net/ethernet}/chelsio/chtls/Makefile (100%)
rename drivers/{crypto => net/ethernet}/chelsio/chtls/chtls.h (81%)
rename drivers/{crypto => net/ethernet}/chelsio/chtls/chtls_cm.c (100%)
rename drivers/{crypto => net/ethernet}/chelsio/chtls/chtls_cm.h (100%)
rename drivers/{crypto => net/ethernet}/chelsio/chtls/chtls_hw.c (100%)
rename drivers/{crypto => net/ethernet}/chelsio/chtls/chtls_io.c (100%)
rename drivers/{crypto => net/ethernet}/chelsio/chtls/chtls_main.c (100%)
Do xfrm offload drivers usually go through the networking tree or
would it be better directed through the xfrm tree?
The drivers go through the networking trees, and I think it should
stay like this. Otherwise we would create needless merge conflicts.
