On Tue, Jul 28, 2020 at 12:16 PM Saeed Mahameed <sae...@mellanox.com> wrote:
> From: Ron Diskin <ro...@mellanox.com>
>
> When setting the PF interface up/down, notify the firmware to update
> uplink state via MODIFY_VPORT_STATE
How this relates to e-switching? the patch touches the e-switch code
but I don't see mentioning of that in the change-log..
> This behavior will prevent sending traffic out on uplink port when PF is
> down, such as sending traffic from a VF interface which is still up.
> Currently when calling mlx5e_open/close(), the driver only sends PAOS
> command to notify the firmware to set the physical port state to
> up/down, however, it is not sufficient. When VF is in "auto" state, it
"auto" is nasty concept that applies only to legacy mode. However, the patch
touches the switchdev mode (representors) code, please explain...
> follows the uplink state, which was not updated on mlx5e_open/close()
> before this patch.
>
> Fixes: 63bfd399de55 ("net/mlx5e: Send PAOS command on interface up/down")
> Signed-off-by: Ron Diskin <ro...@mellanox.com>
> Reviewed-by: Roi Dayan <r...@mellanox.com>
> Reviewed-by: Moshe Shemesh <mo...@mellanox.com>
