On Mon, 27 Jul 2020 14:02:30 +0300 Moshe Shemesh wrote:
> static void mlx5_sync_reset_request_event(struct work_struct *work)
> {
> struct mlx5_fw_reset *fw_reset = container_of(work, struct
> mlx5_fw_reset,
> reset_request_work);
> struct mlx5_core_dev *dev = fw_reset->dev;
> + int err;
>
> + if (test_bit(MLX5_HEALTH_RESET_FLAGS_NACK_RESET_REQUEST,
> &dev->priv.health.reset_flags)) {
> + err = mlx5_fw_set_reset_sync_nack(dev);
> + mlx5_core_warn(dev, "PCI Sync FW Update Reset Nack %s",
> + err ? "Failed" : "Sent");
> + return;
> + }
What if the NACK fails? Does the reset still proceed?
> mlx5_health_set_reset_requested_mode(dev);
> mlx5_reload_health_poll_timer(dev);
> if (mlx5_fw_set_reset_sync_ack(dev))
