On 7/26/2020 12:16 AM, Jiri Pirko wrote:
> Wed, Jul 22, 2020 at 05:30:05PM CEST, jacob.e.kel...@intel.com wrote:
>>
>>
>>> -----Original Message-----
>>> From: netdev-ow...@vger.kernel.org <netdev-ow...@vger.kernel.org> On
>>> Visible in which sense? We don't show components anywhere if I'm not
>>> mistaken. They are currently very rarely used. Basically we just ported
>>> it from ethtool without much thinking.
>>>
>>
>> Component names are used in devlink info and displayed to end users along
>> with versions, plus they're names passed by the user in devlink flash
>> update. As far as documented, we shouldn't add new components without
>> associated versions in the info report.
>
> Okay. So it is loosely coupled. I think it would be nice to tight those
> 2 togeter so it is not up to the driver how he decides to implement it.
>
I felt the coupling was quite clear from Jakub's recent documentation
improvements in the devlink-flash.rst doc file.
Are you thinking find some way to tie these two lists more closely in code?
Thanks,
Jake
