On Mon, Jul 27, 2020 at 5:11 PM Jiri Pirko <j...@resnulli.us> wrote: > Mon, Jul 27, 2020 at 03:29:17PM CEST, andy.shevche...@gmail.com wrote: > >On Mon, Jul 27, 2020 at 3:23 PM Vadym Kochan <vadym.koc...@plvision.eu> > >wrote:
... > >> +err_prestera_dev_register: > >> + free_irq(pci_irq_vector(pdev, 0), fw); > >> +err_request_irq: > >> + pci_free_irq_vectors(pdev); > >> +err_irq_alloc: > >> + destroy_workqueue(fw->wq); > >> +err_wq_alloc: > >> + prestera_fw_uninit(fw); > > > >> +err_prestera_fw_init: > >> +err_pci_dev_alloc: > >> +err_dma_mask: > > > >All three are useless. > > This is okay. It is symmetrical with init. err_what_you_init. It is all > over the place. We use multi-point return and these are inconsistent with the approach. They simple LOCs without value. -- With Best Regards, Andy Shevchenko
