> -----Original Message-----
> From: netdev-ow...@vger.kernel.org <netdev-ow...@vger.kernel.org> On
> Behalf Of Jakub Kicinski
> Sent: Friday, July 17, 2020 12:58 PM
> To: Keller, Jacob E <jacob.e.kel...@intel.com>
> Cc: netdev@vger.kernel.org; Jiri Pirko <j...@resnulli.us>; Tom Herbert
> <t...@herbertland.com>; Jiri Pirko <j...@mellanox.com>; Jakub Kicinski
> <k...@kernel.org>; Jonathan Corbet <cor...@lwn.net>; Michael Chan
> <michael.c...@broadcom.com>; Bin Luo <luob...@huawei.com>; Saeed
> Mahameed <sae...@mellanox.com>; Leon Romanovsky <l...@kernel.org>;
> Ido Schimmel <ido...@mellanox.com>; Danielle Ratson
> <daniel...@mellanox.com>
> Subject: Re: [RFC PATCH net-next v2 0/6] introduce PLDM firmware update
> library
>
> On Fri, 17 Jul 2020 11:35:35 -0700 Jacob Keller wrote:
> > This series goal is to enable support for updating the ice hardware flash
> > using the devlink flash command.
>
> Looks reasonable.
>
> You have some left over references to ignore_pending_flash_update in
> comments, and you should use NLA_POLICY_RANGE() for the new attr.
>
Since the minimum value is zero, I switched the code to use NLA_POLICY_MAX.
Thanks,
Jake
