On Thu, Jul 16, 2020 at 09:28:54PM +0530, Martin Varghese wrote: > From: Martin Varghese <martin.vargh...@nokia.com> > > The commit fe80536acf83 ("bareudp: Added attribute to enable & disable > rx metadata collection") breaks the the original(5.7) default behavior of > bareudp module to collect RX metadadata at the receive. It was added to > avoid the crash at the kernel neighbour subsytem when packet with metadata > from bareudp is processed. But it is no more needed as the > commit 394de110a733 ("net: Added pointer check for > dst->ops->neigh_lookup in dst_neigh_lookup_skb") solves this crash.
This patch looks like a complete revert of fe80536acf83, but with a missing chunk (the rx_collect_metadata field in include/net/bareudp.h). Why not generating this patch with "git revert fe80536acf83", instead of doing it manually?. That'd make sure that no chunk is forgotten. > Fixes: fe80536acf83 ("bareudp: Added attribute to enable & disable rx > metadata collection") > Signed-off-by: Martin Varghese <martin.vargh...@nokia.com>