On Fri, Mar 16, 2007 at 12:50:16PM +0000, David Howells wrote: > Add blkcipher accessors for using kernel data directly without the use of > scatter lists.
I don't quite understand all these indirections. What's the problem with just having a helper that builds the scatterlist for you? > Also add a CRYPTO_ALG_DMA algorithm capability flag to permit or deny the use > of DMA and hardware accelerators. A hardware accelerator may not be used to > access any arbitrary piece of kernel memory lest it not be in a DMA'able > region. Only software algorithms may do that. We allow dma access to arbitary pieces of _dynamically_ allocated kernel memory, and I think using the crypto subsystem on the stack is not allowed at all. But the even bigger question is, how does this relate to rxrpc? > +static inline > +void crypto_blkcipher_decrypt_kernel_iv(struct blkcipher_desc *desc, very odd line split, please put the function name on the same line as the qualifiers, or everything including the void on a line of it's own. The first option seems to be the preffered style in this file. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
