From: Jakub Kicinski <k...@kernel.org> Date: Wed, 15 Jul 2020 17:06:32 -0700
> On Wed, 15 Jul 2020 18:51:55 -0500 Thomas Falcon wrote: >> free_netdev(netdev); >> dev_set_drvdata(&dev->dev, NULL); >> + netdev_info(netdev, "VNIC client device has been successfully >> removed.\n"); > > A step too far, perhaps. > > In general this patch looks a little questionable IMHO, this amount of > logging output is not commonly seen in drivers. All the the info > messages are just static text, not even carrying any extra information. > In an era of ftrace, and bpftrace, do we really need this? Agreed, this is too much. This is debugging, and thus suitable for tracing facilities, at best.
