On 14/07/2020 00:02, Jakub Kicinski wrote:
> On Mon, 13 Jul 2020 12:32:16 +0100 Edward Cree wrote:
>> +MODULE_VERSION(EFX_DRIVER_VERSION);
> We got rid of driver versions upstream, no?
The sfc driver still has a MODULE_VERSION(), I just made this do
the same. Should I instead remove the one from sfc as well?
I assumed there was some reason why it hadn't been included in
the versionectomy so far.
> +static void __exit ef100_exit_module(void)
> +{
> + pr_info("Solarflare EF100 NET driver unloading\n");
> efx_destroy_reset_workqueue(); ?
Sounds like a good idea, yes. Good catch.
> Please remove all the uint32_ts
OK.
Thanks for reviewing.
-ed
