On Mon, Jul 13, 2020 at 05:08:59PM -0700, David Miller wrote: > From: George Kennedy <george.kenn...@oracle.com> > Date: Mon, 13 Jul 2020 07:58:57 -0400 > > > @@ -237,6 +237,8 @@ static int ax88172a_bind(struct usbnet *dev, struct > > usb_interface *intf) > > > > free: > > kfree(priv); > > + if (ret >= 0) > > + ret = -EIO; > > return ret; > > Success paths reach here, so ">= 0" is not appropriate. Maybe you > meant "> 0"?
No, the success path is the "return 0;" one line before the start of the diff. This is always a failure path. regards, dan carpenter
