Re: [PATCH net-next 06/10] net: atlantic: add support for 64-bit reads/writes

[Jakub Kicinski]

On Mon, 13 Jul 2020 14:42:29 +0300 Igor Russkikh wrote:
> +#ifdef CONFIG_X86_64
> +     if (hw->aq_nic_cfg->aq_hw_caps->op64bit)
> +             value = readq(hw->mmio + reg);
> +     else
> +#endif
> +     {
> +             value = aq_hw_read_reg(hw, reg);
> +             value |= (u64)aq_hw_read_reg(hw, reg + 4) << 32;
> +     }

I think you just need to include something like:

#include <linux/io-64-nonatomic-lo-hi.h>

You seem to always access the lower half first.