On Wed, Jul 8, 2020 at 6:18 PM Jakub Kicinski <k...@kernel.org> wrote:
>
> Convert to new infra, taking advantage of sleeping in callbacks.
>
> Signed-off-by: Jakub Kicinski <k...@kernel.org>
> ---
> drivers/net/ethernet/broadcom/bnxt/bnxt.c | 133 ++++++----------------
> drivers/net/ethernet/broadcom/bnxt/bnxt.h | 6 -
> 2 files changed, 34 insertions(+), 105 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h
> b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
> index 78e2fd63ac3d..352a56a18916 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
> @@ -1752,10 +1752,8 @@ struct bnxt {
> #define BNXT_FW_MAJ(bp) ((bp)->fw_ver_code >> 48)
>
> __be16 vxlan_port;
We can also do away with vxlan_port and nge_port, now that we no
longer need to pass the port from NDO to workqueue. We just need to
initialize the 2 firmware tunnel IDs to INVALID_HW_RING_ID before use
and after free. But it is ok the way you have it too.
I like this v2 version better with the VXLAN and GENEVE types defined.
Thanks.
> - u8 vxlan_port_cnt;
> __le16 vxlan_fw_dst_port_id;
> __be16 nge_port;
> - u8 nge_port_cnt;
> __le16 nge_fw_dst_port_id;
> u8 port_partition_type;
> u8 port_count;
