On 7/8/2020 1:44 PM, Linus Walleij wrote:
> Alter the rtl8366_vlan_add() to call rtl8366_set_vlan()
> inside the loop that goes over all VIDs since we now
> properly support calling that function more than once.
> Augment the loop to postincrement as this is more
> intuitive.
>
> The loop moved past the last VID but called
> rtl8366_set_vlan() with the port number instead of
> the VID, assuming a 1-to-1 correspondence between
> ports and VIDs. This was also a bug.
>
> Cc: DENG Qingfang <[email protected]>
> Cc: Mauri Sandberg <[email protected]>
> Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
> Signed-off-by: Linus Walleij <[email protected]>
Reviewed-by: Florian Fainelli <[email protected]>
--
Florian
