On 7/8/20 12:37 PM, David Miller wrote:
> From: "YU, Xiangning" <xiangning...@alibaba-inc.com>
> Date: Thu, 09 Jul 2020 00:38:16 +0800
>
>> @@ -111,7 +111,7 @@ bool irq_work_queue_on(struct irq_work *work, int cpu)
>> return true;
>> #endif /* CONFIG_SMP */
>> }
>> -
>> +EXPORT_SYMBOL_GPL(irq_work_queue_on);
>
> You either removed the need for kthreads or you didn't.
>
> If you are queueing IRQ work like this, you're still using kthreads.
>
> That's why Eric is asking why you still need this export.
>
I removed the kthread for bandwidth sharing.
This IRQ is used to notify other CPUs that it's OK to continue transmission
after rate limiting. We tried other inter-CPU notifications, only IRQ could
achieve a desirable latency.
Thanks,
- Xiangning