On 7/7/20 8:48 PM, Huazhong Tan wrote:
> Add NETIF_F_SOFTWARE_GSO to the the list of GSO features with


s/NETIF_F_SOFTWARE_GSO/NETIF_F_GSO_UDP_L4/

> a software fallback.  This allows UDP GSO to be used even if
> the hardware does not support it, and for virtual device such
> as VxLAN device, this UDP segmentation will be postponed to
> physical device.

Is GSO stack or hardware USO able to perform this segmentation,
with vxlan (or other) added encapsulation ?

What about code in net/core/tso.c (in net-next tree) ?

> 
> Signed-off-by: Huazhong Tan <tanhuazh...@huawei.com>
> ---
>  include/linux/netdev_features.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
> index 2cc3cf8..c7eef16 100644
> --- a/include/linux/netdev_features.h
> +++ b/include/linux/netdev_features.h
> @@ -207,7 +207,7 @@ static inline int find_next_netdev_feature(u64 feature, 
> unsigned long start)
>                                NETIF_F_FSO)
>  
>  /* List of features with software fallbacks. */
> -#define NETIF_F_GSO_SOFTWARE (NETIF_F_ALL_TSO | \
> +#define NETIF_F_GSO_SOFTWARE (NETIF_F_ALL_TSO | NETIF_F_GSO_UDP_L4 | \
>                                NETIF_F_GSO_SCTP)
>  
>  /*
> 

Reply via email to