On Tue, 7 Jul 2020 01:51:21 +0000 Saeed Mahameed wrote: > > Also looks like you report the total number of mcast packets in > > ethtool > > -S, which should be identical to ip -s? If so please remove that. > > why ? it is ok to report the same counter both in ehttool and netdev > stats.
I don't think it is, Stephen and I have been trying to catch this in review for a while now. It's an entirely unnecessary code duplication. We should steer towards proper APIs first if those exist. Using ethtool -S stats gets very messy very quickly in production.
