On 7/6/20 11:19 AM, David Ahern wrote:
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index 82cbb46a2a4f..6451ba313506 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -431,7 +431,7 @@ void fib6_select_path(const struct net *net, struct 
> fib6_result *res,
>       struct fib6_info *sibling, *next_sibling;
>       struct fib6_info *match = res->f6i;
>  
> -     if ((!match->fib6_nsiblings && !match->nh) || have_oif_match)
> +     if (!match->nh && (!match->fib6_nsiblings || have_oif_match))
>               goto out;
>  
>       /* We might have already computed the hash for ICMPv6 errors. In such

of course I notice this after sending the patch. This can actually break
with multipath nexthop objects since it can overwrite the selected path
if done earlier.

DaveM: please drop; will send a v2

Reply via email to