> -----Original Message----- > From: David Miller <[email protected]> > Sent: Saturday, July 4, 2020 1:34 AM > To: Sudarsana Reddy Kalluru <[email protected]> > Cc: [email protected]; Ariel Elior <[email protected]>; Igor Russkikh > <[email protected]>; Michal Kalderon <[email protected]> > Subject: [EXT] Re: [PATCH net-next v2 2/4] bnx2x: Populate database for > Idlechk tests. > > External Email > > ---------------------------------------------------------------------- > From: David Miller <[email protected]> > Date: Fri, 03 Jul 2020 13:03:07 -0700 (PDT) > > > From: Sudarsana Reddy Kalluru <[email protected]> > > Date: Fri, 3 Jul 2020 17:39:48 +0530 > > > >> +/* struct holding the database of self test checks (registers and > >> +predicates) */ > >> +/* lines start from 2 since line 1 is heading in csv */ #define > >> +ST_DB_LINES 468 struct st_record st_database[ST_DB_LINES] = { > > > > This will introduce a build warning because there is no external > > declaration for this global variable. > > > > A patch series must be fully bisectable, meaning that you can't just > > add this declaration in a future patch in the series. It has to be > > added in the same patch where the symbol is defined. > > Actually, looking further, it's even worse. > > You mark it global here, and then mark it static in the next patch. > > Don't do that please.
Dave, thanks for your review and the inputs. Will add the implementation in a single patch, and provide version 3 of the series. Sorry for the inconvenience.
