On Wed,  1 Jul 2020 17:32:47 +0300 Ido Schimmel wrote:
> diff --git a/include/net/devlink.h b/include/net/devlink.h
> index 8f9db991192d..91752b79bb29 100644
> --- a/include/net/devlink.h
> +++ b/include/net/devlink.h
> @@ -68,10 +68,13 @@ struct devlink_port_pci_vf_attrs {
>   * struct devlink_port_attrs - devlink port object
>   * @flavour: flavour of the port
>   * @split: indicates if this is split port
> + * @lanes: maximum number of lanes the port supports.
> + *      0 value is not passed to netlink and valid number is a power of 2.

Why power of two? what about 100G R10?

>   * @switch_id: if the port is part of switch, this is buffer with ID, 
> otherwise this is NULL
>   */
>  struct devlink_port_attrs {
>       u8 split:1;
> +     u32 lanes;
>       enum devlink_port_flavour flavour;
>       struct netdev_phys_item_id switch_id;
>       union {

Reply via email to