On Wed, Jul 01, 2020 at 07:51:27PM +0300, Codrin Ciubotariu wrote:
> The number of ports is incorrectly set to the maximum available for a DSA
> switch. Even if the extra ports are not used, this causes some functions
> to be called later, like port_disable() and port_stp_state_set(). If the
> driver doesn't check the port index, it will end up modifying unknown
> registers.
>
> Fixes: b987e98e50ab ("dsa: add DSA switch driver for Microchip KSZ9477")
Hi Codrin
You don't indicate which tree this is for. net-next, or net? It looks
like it fixes a real issue, so it probably should be for net. But
patches to net should be minimal. Is it possible to do the
ds->num_ports = swdev->port_cnt;
without all the other changes? You can then have a refactoring patch
in net-next.
Thanks
Andrew
