> -----Original Message----- > From: Jakub Kicinski <[email protected]> > Sent: Friday, June 26, 2020 11:57 AM > To: Kirsher, Jeffrey T <[email protected]> > Cc: [email protected]; Michael, Alice <[email protected]>; > [email protected]; [email protected]; [email protected]; > Brady, Alan <[email protected]>; Burra, Phani R <[email protected]>; > Hay, Joshua A <[email protected]>; Chittim, Madhu > <[email protected]>; Linga, Pavan Kumar > <[email protected]>; Skidmore, Donald C > <[email protected]>; Brandeburg, Jesse > <[email protected]>; Samudrala, Sridhar > <[email protected]> > Subject: Re: [net-next v3 13/15] iecm: Add ethtool > > On Thu, 25 Jun 2020 19:07:35 -0700 Jeff Kirsher wrote: > > @@ -978,7 +1059,20 @@ static int iecm_open(struct net_device *netdev) > > */ > > static int iecm_change_mtu(struct net_device *netdev, int new_mtu) { > > - /* stub */ > > + struct iecm_vport *vport = iecm_netdev_to_vport(netdev); > > + > > + if (new_mtu < netdev->min_mtu) { > > + netdev_err(netdev, "new MTU invalid. min_mtu is %d\n", > > + netdev->min_mtu); > > + return -EINVAL; > > + } else if (new_mtu > netdev->max_mtu) { > > + netdev_err(netdev, "new MTU invalid. max_mtu is %d\n", > > + netdev->max_mtu); > > + return -EINVAL; > > + } > > Core already checks this. Please remove all checks which core already does. > > > + netdev->mtu = new_mtu; > > + > > + return iecm_initiate_soft_reset(vport, __IECM_SR_MTU_CHANGE); > > }
Will fix, thanks Alan
