> -----Original Message----- > From: Bartosz Golaszewski <b...@bgdev.pl> > Sent: Monday, June 29, 2020 05:04 > To: Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com>; David S . Miller > <da...@davemloft.net>; Jakub Kicinski <k...@kernel.org>; John Crispin > <j...@phrozen.org>; Sean Wang <sean.w...@mediatek.com>; Mark Lee > <mark-mc....@mediatek.com>; Matthias Brugger > <matthias....@gmail.com>; Heiner Kallweit <hkallwe...@gmail.com>; Andrew > Lunn <and...@lunn.ch>; Florian Fainelli <f.faine...@gmail.com>; Russell King > <li...@armlinux.org.uk>; Rob Herring <robh...@kernel.org>; Frank Rowand > <frowand.l...@gmail.com> > Cc: linux-ker...@vger.kernel.org; netdev@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; linux-media...@lists.infradead.org; > devicet...@vger.kernel.org; Bartosz Golaszewski > <bgolaszew...@baylibre.com> > Subject: [PATCH v2 02/10] net: ethernet: ixgbe: don't call > devm_mdiobus_free() > > From: Bartosz Golaszewski <bgolaszew...@baylibre.com> > > The idea behind devres is that the release callbacks are called if probe > fails. As > we now check the return value of ixgbe_mii_bus_init(), we can drop the call > devm_mdiobus_free() in error path as the release callback will be called > automatically. > > Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> Acked-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
> --- > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-)
