> -----Original Message----- > From: Joe Perches <[email protected]> > Sent: Thursday, June 25, 2020 8:12 PM > To: Kirsher, Jeffrey T <[email protected]>; [email protected] > Cc: Michael, Alice <[email protected]>; [email protected]; > [email protected]; [email protected]; Brady, Alan > <[email protected]>; Burra, Phani R <[email protected]>; Hay, > Joshua A <[email protected]>; Chittim, Madhu > <[email protected]>; Linga, Pavan Kumar > <[email protected]>; Skidmore, Donald C > <[email protected]>; Brandeburg, Jesse > <[email protected]>; Samudrala, Sridhar > <[email protected]> > Subject: Re: [net-next v3 12/15] iecm: Add singleq TX/RX > > On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote: > > From: Alice Michael <[email protected]> > > > > Implement legacy single queue model for TX/RX flows. > [] > > diff --git a/drivers/net/ethernet/intel/iecm/iecm_singleq_txrx.c > > b/drivers/net/ethernet/intel/iecm/iecm_singleq_txrx.c > [] > > @@ -145,7 +508,63 @@ static void iecm_rx_singleq_csum(struct iecm_queue > *rxq, struct sk_buff *skb, > > struct iecm_singleq_base_rx_desc *rx_desc, > > u8 ptype) > > { > [] > > + if (ipv4 && (rx_error & (BIT(IECM_RX_BASE_DESC_ERROR_IPE_S) | > > + BIT(IECM_RX_BASE_DESC_ERROR_EIPE_S)))) > > + goto checksum_fail; > > + else if (ipv6 && (rx_status & > > + (BIT(IECM_RX_BASE_DESC_STATUS_IPV6EXADD_S)))) > > + goto checksum_fail; > > + > > + /* check for L4 errors and handle packets that were not able to be > > + * checksummed due to arrival speed > > + */ > > + if (rx_error & BIT(IECM_RX_BASE_DESC_ERROR_L3L4E_S)) > > + goto checksum_fail; > [] > > +checksum_fail: > > + dev_dbg(rxq->dev, "RX Checksum not available\n"); > > If there's an actual checksum arrival speed issue, then likely this dbg output > should be ratelimited too. >
Yeah this is an issue. I think we want to add a counter here instead of printing anything out anyway. Will fix. Alan
