On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote: > From: Alice Michael <alice.mich...@intel.com> > > This introduces function stubs for the framework of the common > module.
trivia: > diff --git a/drivers/net/ethernet/intel/iecm/iecm_lib.c > b/drivers/net/ethernet/intel/iecm/iecm_lib.c [] > @@ -0,0 +1,407 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* Copyright (C) 2020 Intel Corporation */ > + > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + > +#include <linux/net/intel/iecm.h> > + > +static const struct net_device_ops iecm_netdev_ops_splitq; > +static const struct net_device_ops iecm_netdev_ops_singleq; > +extern int debug; extern int debug doesn't seem like a good global name. extern int iecm_debug? > diff --git a/drivers/net/ethernet/intel/iecm/iecm_main.c > b/drivers/net/ethernet/intel/iecm/iecm_main.c [] > @@ -0,0 +1,47 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* Copyright (C) 2020 Intel Corporation */ > + > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + > +#include <linux/net/intel/iecm.h> > + > +char iecm_drv_name[] = "iecm"; > +#define DRV_SUMMARY "Intel(R) Data Plane Function Linux Driver" > +static const char iecm_driver_string[] = DRV_SUMMARY; > +static const char iecm_copyright[] = "Copyright (c) 2020, Intel > Corporation."; > + > +MODULE_AUTHOR("Intel Corporation, <linux.n...@intel.com>"); > +MODULE_DESCRIPTION(DRV_SUMMARY); > +MODULE_LICENSE("GPL v2"); > + > +int debug = -1; iecm_debug? > +module_param(debug, int, 0644); > +#ifndef CONFIG_DYNAMIC_DEBUG > +MODULE_PARM_DESC(debug, "netif level (0=none,...,16=all), hw debug_mask > (0x8XXXXXXX)"); > +#else > +MODULE_PARM_DESC(debug, "netif level (0=none,...,16=all)"); > +#endif /* !CONFIG_DYNAMIC_DEBUG */ Are debugging levels described?