> > +static int nl_cable_test_ntf_attr(struct nlattr *evattr)
> > +{
> > +   unsigned int cm;
> > +   uint16_t code;
> > +   uint8_t pair;
> > +   int ret;
> > +
> > +   switch (mnl_attr_get_type(evattr)) {
> > +   case ETHTOOL_A_CABLE_NEST_RESULT:
> > +           ret = nl_get_cable_test_result(evattr, &pair, &code);
> > +           if (ret < 0)
> > +                   return ret;
> > +
> > +           printf("Pair: %s, result: %s\n", nl_pair2txt(pair),
> > +                  nl_code2txt(code));
> 
> AFAICS this will produce output like "Pair: Pair A, ..." which looks
> a bit strange, is it intended? (The same below).

Hi Michal

The later patch which adds JSON support changes this. The Pair: gets
removed. I thought it was odd as well. But it did not go back through
the patches and change where is was initially added.

    Andrew

Reply via email to