On Tue, 23 Jun 2020 21:26:02 +0000 Saeed Mahameed wrote:
> On Tue, 2020-06-23 at 14:03 -0700, Jakub Kicinski wrote:
> > On Tue, 23 Jun 2020 12:52:26 -0700 Saeed Mahameed wrote:
> > > From: Vlad Buslov <vla...@mellanox.com>
> > >
> > > en_tc.h header file declares several TC-specific functions in
> > > CONFIG_MLX5_ESWITCH block even though those functions are only
> > > compiled
> > > when CONFIG_MLX5_CLS_ACT is set, which is a recent change. Move
> > > them to
> > > proper block.
> > >
> > > Fixes: d956873f908c ("net/mlx5e: Introduce kconfig var for TC
> > > support")
> >
> > and here... do those break build or something?
>
> No, just redundant exposure and leftovers.
> Do you want me to remove the Fixes Tags ?
> Personally I don't mind fixes tags for something this basic,
> but your call..
If you don't mind - please remove them, IMHO frivolous use of Fixes
tags removes half of their value.
