Hi Jiri, Ido, On Mon, Jun 01, 2020 at 08:24:17AM +0200, Jiri Pirko wrote: > Sat, May 30, 2020 at 05:54:29PM CEST, ido...@idosch.org wrote: > >On Sat, May 30, 2020 at 05:52:31PM +0300, Vadym Kochan wrote: > > [...] > > > >> > WARNING: do not add new typedefs > >> > #1064: FILE: drivers/net/ethernet/marvell/prestera/prestera_hw.h:32: > >> > +typedef void (*prestera_event_cb_t) > >> I may be wrong, as I remember Jiri suggested it and looks like > >> it makes sense. I really don't have strong opinion about this. > > > >OK, so I'll let Jiri comment when he is back at work. > > I was not aware of this warning, but for function callbacks, I think it > is very handy to have them as typedef instead of repeating the prototype > over and over. For that, I don't think this warning makes sense. > > [...]
As I said I have no strong opinion on this, but Jiri's suggestion makes sense. It looks like typedef check was mostly about 'struct' and native types definition. Regards, Vadym Kochan
