On Wed, 17 Jun 2020 11:48:15 -0700 Eric Dumazet wrote: > Transport header size could be 60 bytes, and network header > size can also be 60 bytes. Add the Ethernet header and we > are above 128 bytes. > > Since drivers using net/core/tso.c usually allocates > one DMA coherent piece of memory per TX queue, this patch > might cause issues if a driver was using too many slots. > > For 1024 slots, we would need 256 KB of physically > contiguous memory instead of 128 KB. > > Alternative fix would be to add checks in the fast path, > but this involves more work in all drivers using net/core/tso.c. > > Fixes: f9cbe9a556af ("net: define the TSO header size in net/tso.h") > Signed-off-by: Eric Dumazet <eduma...@google.com> > Cc: Antoine Tenart <antoine.ten...@bootlin.com>
Some warnings popping up in this series with W=1 C=1: drivers/net/ethernet/marvell/octeontx2/af/common.h:65:26: warning: cast truncates bits from constant value (100 becomes 0)