On Wed, Jun 17, 2020 at 8:16 PM Calvin Johnson
<[email protected]> wrote:
>
> From: Jeremy Linton <[email protected]>
>
> Add ACPI support for xgmac MDIO bus registration while maintaining
> the existing DT support.
>
> The function mdiobus_register() inside of_mdiobus_register(), brings
> up all the PHYs on the mdio bus and attach them to the bus.
...
> - snprintf(bus->id, MII_BUS_ID_SIZE, "%llx", (unsigned long
> long)res.start);
> + snprintf(bus->id, MII_BUS_ID_SIZE, "%llx", (unsigned long
> long)res->start);
Since you are here, better to change the specifier to the dedicated
one, i.e. "%pa".
But I don't remember if it adds 0x to it...
...
> +static const struct acpi_device_id xgmac_acpi_match[] = {
> + { "NXP0006", (kernel_ulong_t)NULL },
{ "NXP0006" },
is enough. And I suppose this is the official ID.
> + { },
No need to have comma in terminator line.
> +};
--
With Best Regards,
Andy Shevchenko
