On Wed, Jun 17, 2020 at 07:52:45AM +0300, Maxim Kochetkov wrote:
> Add Marvell 88E1340 support
> Signed-off-by: Maxim Kochetkov <fido_...@inbox.ru>
> ---
> drivers/net/phy/marvell.c | 23 +++++++++++++++++++++++
> include/linux/marvell_phy.h | 1 +
> 2 files changed, 24 insertions(+)
>
> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
> index 7fc8e10c5f33..4cc4e25fed2d 100644
> --- a/drivers/net/phy/marvell.c
> +++ b/drivers/net/phy/marvell.c
> @@ -2459,6 +2459,28 @@ static struct phy_driver marvell_drivers[] = {
> .get_tunable = m88e1540_get_tunable,
> .set_tunable = m88e1540_set_tunable,
> },
> + {
> + .phy_id = MARVELL_PHY_ID_88E1340S,
> + .phy_id_mask = MARVELL_PHY_ID_MASK,
> + .name = "Marvell 88E1340S",
> + .probe = m88e1510_probe,
> + /* PHY_GBIT_FEATURES */
> + .config_init = &marvell_config_init,
> + .config_aneg = &m88e1510_config_aneg,
> + .read_status = &marvell_read_status,
> + .ack_interrupt = &marvell_ack_interrupt,
> + .config_intr = &marvell_config_intr,
> + .did_interrupt = &m88e1121_did_interrupt,
> + .resume = &genphy_resume,
> + .suspend = &genphy_suspend,
> + .read_page = marvell_read_page,
> + .write_page = marvell_write_page,
> + .get_sset_count = marvell_get_sset_count,
> + .get_strings = marvell_get_strings,
> + .get_stats = marvell_get_stats,
> + .get_tunable = m88e1540_get_tunable,
> + .set_tunable = m88e1540_set_tunable,
Can we use a single style for referencing functions please? The kernel
in general does not use &func, it's more typing than is necessary. The
C99 standard says:
6.3.2.1 Lvalues, arrays, and function designators
4 A function designator is an expression that has function type.
Except when it is the operand of the sizeof operator or the unary
& operator, a function designator with type ``function returning
type'' is converted to an expression that has type ``pointer to
function returning type''.
Hence,
.resume = &genphy_resume
and
.resume = genphy_resume
are equivalent but sizeof(genphy_resume) and sizeof(&genphy_resume) are
not.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
