On Tue, Jun 16, 2020 at 10:01:11AM +0300, Maxim Kochetkov wrote:
> Add Marvell 88E1340 support

Hi Maxim

Are you sure this is an 88E1340, not a 88E1340S?

Marvells DSDT SDK has:

    MAD_88E1340S = 0x1C,    /* 88E1340S */
    MAD_88E1340  = 0x1e,    /* 88E1340/x0a */
    MAD_88E1340M = 0x1f,    /* 88E1340M/x0a */
 
>  #define MARVELL_PHY_ID_88E1149R              0x01410e50
>  #define MARVELL_PHY_ID_88E1240               0x01410e30
>  #define MARVELL_PHY_ID_88E1318S              0x01410e90
> +#define MARVELL_PHY_ID_88E1340               0x01410dc0
>  #define MARVELL_PHY_ID_88E1116R              0x01410e40
>  #define MARVELL_PHY_ID_88E1510               0x01410dd0
>  #define MARVELL_PHY_ID_88E1540               0x01410eb0

For 88E1340 i would expect the ID to be 0x01410de0

    Andrew

Reply via email to