On Fri, Jun 05, 2020 at 07:10:02PM +0100, Jonathan McDowell wrote: > This patch documents the qca8k's SGMII related properties that allow > configuration of the SGMII port. > > Signed-off-by: Jonathan McDowell <nood...@earth.li> > --- > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt > b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > index ccbc6d89325d..9e7d74a248ad 100644 > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > @@ -11,7 +11,11 @@ Required properties: > > Optional properties: > > +- disable-serdes-autoneg: Boolean, disables auto-negotiation on the SerDes > - reset-gpios: GPIO to be used to reset the whole device > +- sgmii-delay: Boolean, presence delays SGMII clock by 2ns > +- sgmii-mode: String, operation mode of the SGMII interface. > + Supported values are: "basex", "mac", "phy".
Either these should be common properties and documented in a common spot or they need vendor prefixes. They seem like they former to me (though 'sgmii-delay' would need to be more general and take a time). Rob
